[WPB-6783] Support unblocking an MLS 1-to-1 conversation#3940
Merged
mdimjasevic merged 8 commits intodevelopfrom Mar 13, 2024
Merged
[WPB-6783] Support unblocking an MLS 1-to-1 conversation#3940mdimjasevic merged 8 commits intodevelopfrom
mdimjasevic merged 8 commits intodevelopfrom
Conversation
mdimjasevic
force-pushed
the
wpb-6783/1-1-mls-conversation-when-unblocked
branch
from
56c3136 to
442b067
Compare
zebot
added
the
ok-to-test
mdimjasevic
force-pushed
the
wpb-6783/1-1-mls-conversation-when-unblocked
branch
3 times, most recently
from
8fd5635 to
e6734a4
Compare
mdimjasevic
force-pushed
the
wpb-6783/1-1-mls-conversation-when-unblocked
branch
2 times, most recently
from
340ddaf to
27ca5de
Compare
stefanwire
approved these changes
Mar 12, 2024
Contributor
stefanwire
left a comment
stefanwire
left a comment
There was a problem hiding this comment.
Feel free to ignore the nits.
added 8 commits
March 13, 2024 08:51
This might need some more work, but it's pretty much there. The potentially missing part is what should 'bob1' get on its web socket.
It is not clear yet this is everything that needs to be done. However, it seems like the backend cannot just readd the MLS clients of the user that unblocked the other user, as it has no leaf indices available for a remotely hosted one-to-one conversation.
Moved the logic from `Brig.IO.Intra` to the `GalleyProvider` effect
mdimjasevic
force-pushed
the
wpb-6783/1-1-mls-conversation-when-unblocked
branch
from
7275f59 to
9e016c8
Compare
2 tasks
echoes-hq
bot
added
the
echoes: unplanned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds support for unblocking a user in an MLS 1-to-1 conversation.
Tracked by https://wearezeta.atlassian.net/browse/WPB-6783.
Checklist
changelog.d